Update references in inverter.py #2531
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RDaxini
approved these changes
Aug 13, 2025
|
|
||
| for Grid-Connected Photovoltaic Inverters", Sandia National | ||
| Laboratories, Albuquerque, N.M., USA, SAND2007-5036, Sept. 2007. | ||
| :doi:`10.2172/920449` | ||
| .. [2] System Advisor Model web page. https://sam.nrel.gov. |
There was a problem hiding this comment.
Perhaps we could improve this reference as well. Looking at the citing SAM webpage, I can't see a specific reference for the database. If we just want a general reference, as the current reference is supposed to be, we could go for something like:
Suggested change
| .. [2] System Advisor Model web page. https://sam.nrel.gov. | |
| .. [2] System Advisor Model™ Version 2025.4.16 (SAM™ 2025.4.16). National Renewable Energy Laboratory. Golden, CO. Accessed August 13, 2025. https://sam.nrel.gov. |
This is copied from the citing SAM webpage
There was a problem hiding this comment.
I don't think we should cite a particular verion of SAM, since pvlib doesn't promise that it distributes files from that version. Replacing the CEC module and inverter files with more up-to-date versions is #1345
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
~~ - [ ] Closes #xxxx~~
~~ - [ ] Tests added~~
~~ - [ ] Updates entries in
docs/sphinx/source/referencefor API changes.~~docs/sphinx/source/whatsnewfor all changes. Includes link to the GitHub Issue with:issue:`num`or this Pull Request with:pull:`num`. Includes contributor name and/or GitHub username (link with:ghuser:`user`).remote-data) and Milestone are assigned to the Pull Request and linked Issue.Adding DOI for Sandia report and one A. Driesse paper, aligning with format for citations.